Code action to convert between computed property and stored property

[antigluten]

Resolves swiftlang/sourcekit-lsp#1245

[antigluten]

Thanks for review, @ahoppen!

[ahoppen]

Thanks for the adjustments. I have a few comments, mostly regarding trivia handling. The overall shape looks good. It would also be good to add test cases for the examples that I mentioned.

[antigluten]

Need help with the testToStoredWithReturnStatementAndTrailingCommentOnNewLine, I have no idea how to handle the trailing trivia that contains comments, so to not break another test

Test: testToStoredWithReturnStatementAndTrailingCommentOnNewLine

let baseline: DeclSyntax = """
  var defaultColor: Color {
    return Color()
    /* some text */
  }
  """

let expected: DeclSyntax = """
  let defaultColor: Color = Color()
  /* some text */
  """

Test: testToStoredWithReturnStatementAndTrailingComment

let baseline: DeclSyntax = """
  var defaultColor: Color {
    return Color() /* some text */
  }
  """

let expected: DeclSyntax = """
  let defaultColor: Color = Color() /* some text */
  """

[ahoppen]

How about adding the trivia of the dropped braces to the initializer?

Ie something like

initializer.leadingTrivia = accessorBlock.leftBrace.leadingTrivia + accessorBlock.leftBrace.trailing + initializer.leadingTrivia
initializer.trailingTrivia += accessorBlock.rightBrace.leadingTrivia + accessorBlock.rightBrace.trailing

[antigluten]

@ahoppen, done

[ahoppen]

The results are looking great!

[ahoppen]

Looking great. Let’s get this merged.

[ahoppen]

@swift-ci Please test

[kimdv]

@swift-ci please test

[kimdv]

@swift-ci please test windows

[ahoppen]

@swift-ci Please test Linux