[SR-8332] [Source Compat] Breakage: fluent -- missing argument, does not conform, type has no member

[clackary]

Previous ID	SR-8332
Radar	rdar://problem/42435686
Original Reporter	@clackary
Type	Bug
Status	Resolved
Resolution	Done

Additional Detail from JIRA

Votes	0
Component/s
Labels	Bug, SourceCompatibility
Assignee	None
Priority	Medium

md5: e715c0e69080aee00b6d8fb0cefe7875

Issue Description:

ci.swift.org log: https://ci.swift.org/job/swift-PR-source-compat-suite-test-macOS/274/artifact/swift-source-compat-suite/FAIL_fluent_4.2_BuildSwiftPackage.log

To reproduce:

1. Install latest GM/Beta Xcode
2. $ git clone git@github.com:apple/swift-source-compat-suite.git
3. $ cd swift-source-compat-suite
4. $ git checkout add-fluent
5. (Un-apply xfail patch locally) $ git show ae01b83cc435d | git apply -R

To build Swift from scratch before testing:
6a. $ ./reproduce.py master --project-path fluent

Or if you've already built Swift:
6b. $ ./reproduce.py master --project-path fluent --swiftc path/to/swiftc

/Users/buildnode/jenkins/workspace-private/swift-PR-source-compat-suite-test-macOS/project_cache/fluent/.build/checkouts/database-kit-c669b89b/Sources/DatabaseKit/Connection/Container+NewConnection.swift:23:28: error: missing argument for parameter #​1 in call
                conn.close()
                           ^
                           <#_#>
/Users/buildnode/jenkins/workspace-private/swift-PR-source-compat-suite-test-macOS/project_cache/fluent/.build/checkouts/database-kit-c669b89b/Sources/DatabaseKit/Database/DatabaseConfig.swift:72:30: error: argument type 'D.Connection' does not conform to expected type 'Worker' (aka 'EventLoopGroup')
            return .done(on: conn)
                             ^~~~
                                  as! Worker
/Users/buildnode/jenkins/workspace-private/swift-PR-source-compat-suite-test-macOS/project_cache/fluent/.build/checkouts/database-kit-c669b89b/Sources/DatabaseKit/Utilities/Deprecated.swift:39:16: error: value of type 'D.Connection' has no member 'close'
        return conn.close()
               ^~~~ ~~~~~

[clackary]

@swift-ci create

[clackary]

Note that this project has not been added to the suite yet. The log shown above is from the pull request test output. To reproduce this, step #4 is required, as the project configuration does not exist on master.

[clackary]

Pull request to add fluent to the suite: swiftlang/swift-source-compat-suite#223

I've xfailed the project so that we can finish getting it added.

[DougGregor]

This got fixed by #18868