build-script: always rebuild XCTest on non-Darwin #19512
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
Member
Author
|
@swift-ci please test |
This should resolve SR-8826! Ideally, we would be using CMake to tie together all the dependent packages and get proper dependency tracking. Currently, change to the swift runtime do not get tracked properly, and can result in undefined references to symbols.
compnerd
force-pushed
the
cleanup-on-aisle-xctest
branch
from
18d8965 to
ab56873
Compare
Member
Author
|
@swift-ci please test and merge |
1 similar comment
Member
Author
|
@swift-ci please test and merge |
edymtt
added a commit
to edymtt/swift
that referenced
this pull request
Mar 31, 2021
Introduce a new parameter `--skip-llbuild-clean` to prevent this from happening. This mimicks similar logic in place for `swiftpm`, `swift-driver` (swiftlang#33563) and `xctest` (swiftlang#19512) Addresses rdar://75057069
edymtt
added a commit
that referenced
this pull request
Apr 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should resolve SR-8826! Ideally, we would be using CMake to tie together
all the dependent packages and get proper dependency tracking. Currently,
change to the swift runtime do not get tracked properly, and can result in
undefined references to symbols.
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.