[benchmark] Refactor Package.swift manifest file #20120
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a NFC commit which cleans up the SwiftPM manifest file used for benchmark testing. The manifest can be further improved by removing the side-effects in the future.
Contributor
|
We need an integration test that builds the benchmark suite using swiftpm before this lands. Feel free to add it if you want. I am juggling a bunch of things, so I am not sure exactly when I will be able to get to it. |
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a NFC commit which cleans up the SwiftPM manifest file used for
benchmark testing. The manifest can be further improved by removing the
side-effects in the future.