[test] Style fixes for "Modify test scripts for aarch64 and modern NDKs" #23506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some style fixes that @compnerd proposed in PR swiftlang#19503. - Instead of checking for the two known ARMv7 subarchitectures, check for everything that starts with armv7 and consider it armv7. - Try finding the current platform to select the right prebuilt directory for the NDK tools. - Use -isystem for the system header includes when passing them to clang. - Modify the format strings which started to be very wild into simpler `' '.join([...])` which, IMO, read better. - Hoist some common path parts to not repeat the same long paths in a couple of places. - Add more library search paths (missing for atomic)
compnerd
approved these changes
Mar 23, 2019
Member
compnerd
left a comment
compnerd
left a comment
There was a problem hiding this comment.
The ' '.join([...]) is wildly better to follow than the format, that helps this quite a bit.
| # TODO: NDK distributes for Windows 32 and 64 bits. platform.machine() | ||
| # should allow us to find out the word size, but I don't have a | ||
| # machine to test right now. I think the values are AMD64 and x86, but | ||
| # I'm not sure. Everybody gets the 64 bits version for now. |
Member
There was a problem hiding this comment.
More bits is more better right? :-p
Member
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some style fixes that @compnerd proposed in PR #19503.
clang.
' '.join([...])which, IMO, read better.couple of places.