[tests] Add mechanism to override lit environment #27560
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lit runs its tests with only the environment variables set up by its configuration, which is great for repeatability, but sometimes you want to allow a few controlled leaks. With this change, you can now specify “--param copy_env=FOO:BAR:BAZ” to cause the environment variables FOO, BAR, and BAZ to be visible in lit tests during that run.
Contributor
Author
|
@swift-ci please smoke test |
Contributor
Author
|
Linux failure looks unrelated; I'm hoping it's intermittent. @swift-ci please smoke test linux platform |
Collaborator
|
Linux PR testing has been broken since a few days, it should be fixed by swiftlang/swift-corelibs-foundation#2532 when merged. |
Contributor
Author
|
@swift-ci please smoke test |
Contributor
Unfortunately 2532 also fails to test, so I'm not sure where that puts us right now. |
Contributor
Author
|
@swift-ci please smoke test linux platform |
1 similar comment
Contributor
Author
|
@swift-ci please smoke test linux platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lit runs its tests with only the environment variables set up by its configuration, which is great for repeatability, but sometimes you want to allow a few controlled leaks. With this change, you can now specify
--param copy_env=FOO:BAR:BAZto cause the environment variablesFOO,BAR, andBAZto be visible in lit tests during that run.