[build-script-impl] Add flag for building SourceKit on Linux #3170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Note that one can use |
| build-swift-examples "1" "set to 1 to build examples" | ||
| build-serialized-stdlib-unittest "0" "set to 1 to build the StdlibUnittest module with -sil-serialize-all" | ||
| build-sil-debugging-stdlib "0" "set to 1 to build the Swift standard library with -gsil to enable debugging and profiling on SIL level" | ||
| build-sourcekit "" "set to build the SourceKit library and tools (enabled by default on Darwin hosts)" |
Contributor
There was a problem hiding this comment.
Could you lift the computation of the default value into the Python script? Maybe as a separate patch.
Contributor
Author
|
Sorry for never following up on this. Shortly after opening this I was unable to continue working on SourceKit for Linux. I'm going to close this as I don't think it's very relevant at this point. For reference, this comment describes what is currently required to get a SourceKit build on Linux: #3594 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
Significant progress is being made towards getting SourceKit buildable on Linux. This adds a temporary switch to
build-script-implfor enabling SourceKit in the CMake build, to facilitate others who are interested in following this work.cc @akyrtzi @benlangmuir @gribozavr
Resolved bug number: (SR-1676)
Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
Validation Testing
Lint Testing
Note: Only members of the Apple organization can trigger swift-ci.