[android] Add support for x86_64 arch #34661
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compnerd
approved these changes
Nov 11, 2020
Member
compnerd
left a comment
compnerd
left a comment
There was a problem hiding this comment.
Yeap, though I've always just built it with direct invocations of CMake.
Member
Author
|
Updated only to fix the |
Contributor
|
@swift-ci please smoke test |
Member
Author
|
Windows test failure is unrelated. |
Contributor
|
@swift-ci please test Windows platform |
Contributor
|
⛵ |
Member
Author
|
Thanks for the quick turnaround. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was able to cross-compile the stdlib, corelibs, and SPM using this pull and a tweaked #33724. I have kicked off a full toolchain build and
willno further update to this pullifwas needed, termux/termux-packages#6014.@compnerd and @vgorloff, looks like you two have been building this before.