[test] This test should check for codegen support. #35505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
ping. |
3405691582
force-pushed
the
CheckForArm
branch
from
139fe1e to
78f246e
Compare
These tests checks for x86_64-* targets and armv7-* targets. If LLVM is not built with support for these targets, these tests will trip. It appears the way to check for this is by REQUIRES CODEGENERATOR, so add this to properly condition these tests.
3405691582
force-pushed
the
CheckForArm
branch
from
78f246e to
d602a69
Compare
Member
Author
|
cc @zoecarver |
Member
Author
|
ping. Would it be perhaps be more desirable to shard this test instance per architecture, perhaps? |
Member
|
It looks like Egor subsequently specialized these much more in #60603, so you may simply want to add OpenBSD versions instead to this pull and we can get that in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test checks for x86_64-* targets and armv7-* targets. If LLVM is
not built with support for these targets, this test will trip. It
appears the way to check for this is by REQUIRES CODEGENERATOR, so add
this to properly condition this test.