[5.4][SwiftShims] Make the arguments of memcmp nullable on Darwin #37626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should correspond to the definition of memcmp in usr/include/string.h and keep it from being a source of confusion for the compiler. rdar://69876253 rdar://78270152
Contributor
Author
|
@swift-ci Please test |
Contributor
Author
|
@swift-ci Please smoke test |
Contributor
Author
|
@swift-ci Please nominate |
airspeedswift
approved these changes
May 25, 2021
Contributor
|
Build failed |
Contributor
Author
|
@swift-ci Please test macOS platform |
AnthonyLatsis
added
swift 5.4
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mark the arguments of
memcmpin SwiftShims with_Nullableon Darwin. This realigns the nested prototype ofmemcmpfrom SwiftShims with the definition inusr/include/string.hand keep it from being a source of confusion for the compiler.memcmpcaused compiler crash in projects that usedmemcmpdirectly or usedData == Datawith optimizations enabled that replaced it with amemcmpcall.memcmpshould remain valid.memcmpless obvious, making this inconsistency visible.