Mark android_cross_compile.test unsupported for iOS, tvOS, and watchOS #38279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Member
Author
|
cc: @buttaface |
shahmishal
deleted the
shahmishal/disable-android_cross_compile-test-darwin
branch
Member
|
There appears to be something strange where build system tests like this, that have nothing to do with Apple platforms and that don't invoke any Apple-related flags, are still forced to build for Apple platforms on macOS. I cannot diagnose this since I don't use macOS and this test passed the Mac CI, so disabling this for Apple platforms makes sense to me. @gottesmm, you recommended adding this test, let me know if you think we should change anything. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.