[cxx-interop] Fix assertion failure when looking up C++ operators #59345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously when looking up a C++ operator (e.g. `==`), `ClangImporter::Implementation::lookupValue` returned a Swift function with a generated name (e.g. `func __operatorEqualEqual`), while the caller expected the result to be a Swift operator (e.g. `func ==`). This change makes sure that we're returning a synthesized Swift operator when looking for a C++ operator. This fixes an assertion failure in the typechecker: ``` swift-frontend: /home/build-user/swift/lib/Sema/ConstraintSystem.cpp:1454: std::pair<Type, Type> swift::constraints::ConstraintSystem::getTypeOfReference(swift::ValueDecl *, swift::FunctionRefKind, swift::constraints::ConstraintLocatorBuilder, swift::DeclContext *): Assertion `func->isOperator() && "Lookup should only find operators"' failed. ```
Contributor
Author
|
@swift-ci please smoke test |
Contributor
Author
|
This is a requirement for #58699. |
Contributor
Author
|
Merging to unblock other work, happy to discuss post-merge. |
Huddie
reviewed
Jun 10, 2022
Contributor
Huddie
left a comment
Huddie
left a comment
There was a problem hiding this comment.
This is really nice! Great commenting! 👍 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously when looking up a C++ operator (e.g.
==),ClangImporter::Implementation::lookupValuereturned a Swift function with a generated name (e.g.func __operatorEqualEqual), while the caller expected the result to be a Swift operator (e.g.func ==).This change makes sure that we're returning a synthesized Swift operator when looking for a C++ operator.
This fixes an assertion failure in the typechecker: