[Threading] Support 32-bit platforms for C11 threads and pthreads. #59586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We just need to change the type from `int64_t` to `intptr_t`. rdar://95523756
Contributor
Author
|
@swift-ci Please test |
Contributor
Author
|
@compnerd While this isn't a Windows change, it's essentially what you already did for the Windows version, so I thought I'd ask you to take a quick look and make sure I didn't do anything silly. |
Member
|
I can confirm this pull fixes the pthreads issue on Android armv7. |
compnerd
approved these changes
Jun 20, 2022
Member
compnerd
left a comment
compnerd
left a comment
There was a problem hiding this comment.
LGTM. One thing that I did do differently on Windows was adopt the C++ style casts. I don't think that is important but something nice to follow in C++.
Contributor
Author
|
@swift-ci Please test Linux platform. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We just need to change the type from
int64_ttointptr_t.rdar://95523756