stdlib: install SwiftGlibc.h in static resources directory #62209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When SwiftGlibc.h was added in swiftlang#32404, no cmake code was added to copy it to the static resources. Copy it along with glibc.modulemap, which references it.
egorzhdan
approved these changes
Nov 22, 2022
Contributor
egorzhdan
left a comment
egorzhdan
left a comment
There was a problem hiding this comment.
This looks good to me, thanks!
Contributor
|
@swift-ci please smoke test |
Contributor
|
@swift-ci please smoke test macOS |
compnerd
approved these changes
Nov 22, 2022
Member
compnerd
left a comment
compnerd
left a comment
There was a problem hiding this comment.
The re-ordering made the diff more difficult to read. It would be nice to split that out in the future.
Contributor
Author
|
Looks like tests passed. Could someone merge, please? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When SwiftGlibc.h was added in #32404, no cmake code was added to copy it to the static resources. Copy it along with glibc.modulemap, which references it.