[sourcekitd] Allow client to enable use of dispatch barriers for open/edit/close on the message handling queue #66013
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@swift-ci Please smoke test |
Member
Author
|
@swift-ci Please SourceKit stress test |
ahoppen
force-pushed
the
ahoppen/sourcekitd-barriers
branch
from
581ce83 to
d4ffe40
Compare
Member
Author
|
@swift-ci Please test |
Member
Author
Member
Author
|
@swift-ci Please test macOS |
ahoppen
changed the title
ahoppen
changed the title
bnbarham
approved these changes
Jun 6, 2023
rintaro
approved these changes
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we relied on the client to make sure any open/edit/close request has finished executing before sending semantic queries about that updated source file, implicitly relying on clients to provide synchronization guarantees. This enables a mode in which sourcekitd can provide those synchronization guarantees:
By default, all behavior stays the same. After the client sends a
source.request.enable_request_barriersrequest,sourcekitdwill issue all open/edit/close requests as dispatch barriers. This makes sure that all requests after the open/edit/close will only start being handled after the open/edit/close has finished.