[Macros] Tighten restriction on non-expression macros not having return types #66526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@swift-ci please smoke test and merge |
This was referenced Jun 10, 2023
Member
Author
|
Hehehehe. Our standard library does this: /Users/ec2-user/jenkins/workspace/swift-PR-macos-smoke-test/branch-main/build/buildbot_incremental/swift-macosx-x86_64/lib/swift/macosx/Swift.swiftmodule/x86_64-apple-macos.swiftinterface:12610:72: error: only a freestanding expression macro can produce a result of type '()'
@freestanding(declaration) public macro error(_ message: Swift.String) -> () = Builtin.ErrorMacro
^ ~~We'll need to stage in this bit. Correction: the module interface printer does this, not the standard library itself. |
…rn types There is no reason to special-case `Void` to permit it. Rather, make this a syntactic rule. Thanks to Alex Hoppen for the suggestion.
…terfaces This allows us to continue to accept Swift interface files created with older versions of the Swift 5.9 compiler that emitted a spurious `-> ()` on non-expression macro declarations.
DougGregor
force-pushed
the
non-expression-macro-no-void
branch
from
ca5cbd2 to
f7de3a3
Compare
Member
Author
|
@swift-ci please smoke test |
ahoppen
reviewed
Jun 11, 2023
Comment on lines
+2079
to
+2080
| auto resultType = MD->getResultInterfaceType(); { | ||
| auto diag = Ctx.Diags.diagnose( |
Member
There was a problem hiding this comment.
This looks really odd to me. Why do you open a new brace scope at the same line as
auto resultType = MD->getResultInterfaceType();
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no reason to special-case
Voidto permit it. Rather, make this a syntactic rule. Thanks to Alex Hoppen for the suggestion.