Replace a cmake option with a preprocessor macro. #7469
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When moving to the swift-4.0-branch of LLVM, we started using the LLVM_DISABLE_ABI_BREAKING_CHECKS_ENFORCING cmake option to turn off those checks. This was necessary for the stdlib build, where it uses some LLVM headers without linking libSupport.a, but the cmake option forced us to disable the checks across the board. It also caused a lot of churn for people who needed to remove their cmake caches when switching to the new version of LLVM. This change switches to use a preprocessor macro to disable the checks only in the context of the stdlib build. It requires LLVM r295090. rdar://problem/30098953
Contributor
Author
|
I need to hold onto this until the LLVM change propagates to the stable branch. |
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
I'm going to hold this for a bit longer to make it more likely that people will have updated their LLVM builds and will not be impacted by this. |
Contributor
Author
|
I'm planning to merge this tomorrow (Friday). I sent a heads-up message to swift-dev. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When moving to the swift-4.0-branch of LLVM, we started using the
LLVM_DISABLE_ABI_BREAKING_CHECKS_ENFORCING cmake option to turn off those
checks. This was necessary for the stdlib build, where it uses some LLVM
headers without linking libSupport.a, but the cmake option forced us to
disable the checks across the board. It also caused a lot of churn for
people who needed to remove their cmake caches when switching to the new
version of LLVM. This change switches to use a preprocessor macro to
disable the checks only in the context of the stdlib build. It requires
LLVM r295090. rdar://problem/30098953