[6.0] [loadable by address reg2mem] Implement missing throw instruction #76457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes swiftlang#71744 Cherry-picked from a63078f rdar://135227988
Description: Fixes a missing case to large types reg2mem. Without adding this case asserts compiler will complain and cause the compiler to crash. Risk: Low. This is the same code that we would have generated with an no-asserts compiler where we fallback to a solution that loads and stores back to memory. Scope: Fixes a compiler crasher in asserts toolchains. Testing: Regression test added. rdar://134914984 (cherry picked from commit eeaf962)
Contributor
Author
|
@swift-ci test |
DougGregor
approved these changes
Dec 3, 2024
Member
DougGregor
left a comment
DougGregor
left a comment
There was a problem hiding this comment.
We'll take this; it's been thoroughly vetted and addresses an assertion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Fixes a missing case to large types reg2mem. Without adding
this case asserts compiler will complain and cause the compiler to
crash.
Risk: Low. This is the same code that we would have generated with an no-asserts
compiler where we fallback to a solution that loads and stores back to memory.
Scope: Fixes a compiler crasher in asserts toolchains.
Testing: Regression test added.
rdar://134914984