[AutoDiff] Enhance performance of custom derivatives lookup #76951
Conversation
|
Tagging @asl |
In swiftlang#58965, lookup for custom derivatives in non-primary source files was introduced. It required triggering delayed members parsing of nominal types in a file if the file was compiled with differential programming enabled. This patch introduces `CustomDerivativesRequest` to address the issue. We only parse delayed members if tokens `@` and `derivative` appear together inside skipped nominal type body (similar to how member operators are handled). Resolves swiftlang#60102
kovdan01
requested review from
CodaFi,
DougGregor,
ahoppen,
bnbarham,
hamishknight,
hborla,
rintaro,
slavapestov and
xedin
as code owners
|
@swift-ci please test |
|
@slavapestov This implements your request from #58965 (comment) |
|
Would be glad to see feedback from everyone interested |
|
Also tagging @rxwei |
|
Would be glad to see feedback from everyone interested |
DougGregor
left a comment
DougGregor
left a comment
There was a problem hiding this comment.
This looks good! I have one non-actionable comment, but let's go ahead and merge
| if (onlyDerivatives) | ||
| if (AbstractFunctionDecl *AFD = getDerivative()) | ||
| CustomDerivatives.push_back(AFD); | ||
| if (!onlyOperators && !onlyDerivatives && VD->hasName()) { | ||
| TopLevelValues.add(VD); | ||
| if (VD->getAttrs().hasAttribute<CustomAttr>()) | ||
| MayHaveAuxiliaryDecls.push_back(VD); | ||
| } | ||
| if (AbstractFunctionDecl *AFD = getDerivative()) | ||
| CustomDerivatives.push_back(AFD); |
There was a problem hiding this comment.
I don't have a specific suggestion on how to improve it, but this logic was a little tangled before with onlyOperators and now it's... really hard to sort through.
There was a problem hiding this comment.
Thanks for bringing attention to this! I agree that the logic is pretty complicated and should be simplified somehow. I was also unable to quickly find a nice way to fix this, but I'll think of it and submit a subsequent PR once the refactoring of this function is ready.
|
@swift-ci please smoke test |
|
Kicking off CI once more just to be sure, then once it's green let's merge |
3 participants
In #58965, lookup for custom derivatives in non-primary source files was
introduced. It required triggering delayed members parsing of nominal types in
a file if the file was compiled with differential programming enabled.
This patch introduces
CustomDerivativesRequestto address the issue.We only parse delayed members if tokens
@andderivativeappeartogether inside skipped nominal type body (similar to how member operators
are handled).
Resolves #60102