[pull] swiftwasm from main #5525
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReflectionContext::allocationMetadataPointer() was reading the metadata pointer from a wrong offset because of the out-of-sync struct layouts and dump-generic-metadata was not working correctly. This change resync's the layouts and adds a static_assert to verify that the offsets match between GenericMetadataCacheEntry and GenericCacheEntry.
SyntaxRewriters should use `rewrite` to create a new node, not `visit`.
`lib/swift/host` contains modules/libraries that are built by the host compiler. Their `.swiftmodule` will never be able to be read, ignore them entirely.
'self' within init accessor could only be used to refer to properties listed in `initializes` and `accesses` attributes.
…s within init accessors Only properties that are listed in 'initializes' and 'accesses' attributes could be referenced within init accessor. Detect any and all invalid member references in the solver.
…s within init accessors
…gnostics within init accessors
…d before every terminator
This closes a hole where an early return could leave some
properties from `initializes(...)` list uninitialized.
For example:
```swift
init(initialValue) initializes(_a, _b) {
_a = initialValue.0
if _a > 0 {
return
}
_b = initialValue.1
}
```
Here `_b` is not initialized when `_a > 0`.
… memberwise init If init accessor initialize the same properties, let's emit them in sequence and emit `destroy_addr` in-between to make sure that there is no double initialization.
… be synthesized If some of the properties with init accessors have out of order accesses diagnose that while checking whether memberwise init could be synthesized.
…tializes` intersect If some property is initializable by one than one init accessor let's not sythesize a memberwise initializer in that case because it's ambiguous what is the best init accessor to use.
…mberwise initializable
…ors should follow field order Skip stored properties that are initialized via init accessors and emit parameters/initializations in field order which allows us to cover more use-cases.
@objcImpl extensions aren’t allowed to declare new conformances; instead, they should either be declared in the header or in an ordinary extensions. (If they were permitted, they’d be ignored.) Fixes rdar://110669366.
We have two stacks that we set up during crash handling, both of which were potentially misaligned. This only tripped us up on Ubuntu 20.04 on aarch64 - my guess is that maybe `clone()` aligns the stack pointer on newer kernels which is why we didn't see it on 22.04. rdar://110743884
…ows-vs2022 Fix tests on Windows CI with VS2022
[Backtracing][Linux] Properly align the stacks.
Section scans (for metadata, protocols, etc.) can be costly. This change adds tracing calls to those scans so we can more easily see how much time is spent in these scans and where they're initiated. This adds an os_signpost implementation controlled by SWIFT_STDLIB_TRACING, and a default empty implementation for when that's disabled. rdar://110266743
…enum (swiftlang#66621) Instantiating layout strings for generic types reduces code size and is expected to improve performance of generic value witnesses.
[Test] Use SyntaxRewriter.rewrite not visit
[Frontend] Ignore adjacent swiftmodule in compiler host modules
[Sema/SIL] Improve diagnostics related to init accessors
[Runtime] Add tracing for section scans.
Diagnose conformances on @objcImpl extensions
Fix the swift-inspect dump-generic-metadata operation.
…meterized-protocol AST: Fix logic error in TypeMatcher::visitParameterizedProtocolType()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )