settings: Add Grid Count and Sort Settings#96
Merged
Ericgacoki merged 5 commits intomainfrom Dec 13, 2025
Merged
Conversation
Adds a new feature module `feature:settings` to manage application-wide settings. This initial implementation uses DataStore to persist the grid layout count for the Albums and Artists screens. Key changes: - Created `AppSettings` DataStore wrapper. - Implemented `AppSettingsRepository` to abstract data access. - Injected the repository into `AllAlbumsViewModel` and `ArtistsViewModel`. - Grid count state is now fetched from and updated to the DataStore, ensuring persistence.
This commit introduces the ability to persist sorting preferences for albums and artists in the app settings. - Added `SortBy` and `SortOrder` to `AppSettingsRepository` and `AppSettingsDataRepository`. - Implemented storing and retrieving sort preferences using `DataStore`. - Updated `AllAlbumsViewModel` and `ArtistsViewModel` to use and update the persisted sort settings. - Refactored ViewModels to use `combine` for observing multiple settings flows.
…interceptor - Refactor `ArtistsViewModel` and `AllAlbumsViewModel` to observe grid count separately from sort settings. - Apply `distinctUntilChanged()` to sort order and sort by flows to prevent unnecessary updates. - Remove redundant calls to `getPagingArtists` and `getPagingAlbums` inside event handlers, as they are now reactive to setting changes. - Add Chucker interceptor to `AuthModule` for HTTP inspection in debug builds. - Add `tools:node="replace"` to WAKE_LOCK permission in AndroidManifest. This prevents Chucker from removing this permission on Android 8+
|
Eric Gacoki seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.