backstage: Upgrade react to 18 on branch smartshift-smith-m-1690306439 #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code change in this git diff is about adding a new prop to the OnDemandCard component in React. 1. A new prop named 'children' is added to the prop type definition of the OnDemandCard component. This prop is optional and its type is React.ReactNode. ReactNode includes all types that a render method can return, so it can be a string, a number, a React element, an array, or even a function. ```typescript children?: React.ReactNode; ``` This change is made to explicitly list the 'children' prop when defining props. This is useful when you want to render some content inside the component and you don't know what that content will be ahead of time. It could be text, another React component, or nothing at all. By adding 'children' to the prop types, you're telling TypeScript that this component can accept children and they can be of any type that a render method can return.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backstage
Tasks
Update TypeScript definitions
If your project uses TypeScript, you will need to update your @types/react and @types/react-dom dependencies to the latest versions.
Instructions
Upgrade repo
npm upgrade
Instructions
Errors