backstage: Upgrade react to 18 on branch smartshift-smith-m-1690307283 #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code change in this git diff is about adding a new prop to the OnDemandCard component in React. 1. A new prop named 'children' of type 'React.ReactNode' is added to the props definition of the OnDemandCard component. This prop is optional as indicated by the '?' symbol. This means that the 'children' prop can be used to pass any valid React node (like JSX elements, strings, numbers, etc.) as children to the OnDemandCard component. If no 'children' prop is passed, it will be undefined. 2. No other changes are made to the component's implementation, meaning the 'children' prop is not yet used within the component. This change only extends the component's API to accept this new prop. Future changes might use this prop to render additional content within the OnDemandCard component.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backstage
Tasks
Update TypeScript definitions
If your project uses TypeScript, you will need to update your @types/react and @types/react-dom dependencies to the latest versions.
Instructions
Upgrade repo
npm upgrade
Instructions
Errors