[LiveComponent] Support default value for new collection item#3117
Open
IndraGunawan wants to merge 1 commit intosymfony:2.xfrom
Open
[LiveComponent] Support default value for new collection item#3117IndraGunawan wants to merge 1 commit intosymfony:2.xfrom
IndraGunawan wants to merge 1 commit intosymfony:2.xfrom
Conversation
carsonbot
changed the title
IndraGunawan
force-pushed
the
set-item-default-value
branch
from
f85753e to
61f61ef
Compare
IndraGunawan
force-pushed
the
set-item-default-value
branch
from
61f61ef to
e125ad5
Compare
smnandre
changed the title
Member
|
Hi @IndraGunawan ! Could you update the CHANGELOG and documentation ? |
smnandre
reviewed
Oct 3, 2025
| } | ||
|
|
||
| protected function setCollectionItemDefaultValue(string $propertyPath, int $index): iterable | ||
| { |
Member
There was a problem hiding this comment.
Could you add an integration or functional test here ?
(To prevent any future regression)
We can guide or help if you want to :)
smnandre
added
Status: Waiting feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when adding a new item to a collection of
LiveCollectionType, it was always an empty valuesomehow, defining
prototype_datais not workingso this introduces a new method to set the default value of a collection item