Single Fork Writes PID

[symkat]

Single fork mode currently tries to write the PID file, although this is not the documented behavior.

Single-fork was meant explicitly to just give you start/stop/restart functionality for something that will otherwise daemonize itself. Part of daemonizing itself is writing the PID file, since something daemonizing should follow the standard double-fork, therefore I cannot know what the PID of the eventually-lauched process is.

Daemon::Control writing to the PID file in this case is a bug.

[ ] Remove the writing of the PID file in sub _fork
[ ] Confirm the rest of the code is sane in single fork mode.

[karenetheridge]

If the calling app hangs on to the Daemon::Control object, then it can call ->write_pid itself, after forking. (This could be a recommendation in the documentation, so the user doesn't try to reimplement pid functionality himself.)

[karenetheridge]

Just noticed another thing - when this is fixed, you should be able to remove the fork() in write_pid(), as you'll now only be writing a pid file after you've switched to the new uid/guid, so there won't be any permissions issues.

[symkat]

This has been corrected -- the PID is no longer written as it is the daemon's responsibility to write the PID file when using single fork, and Daemon::Control's job is only to load the PID from the file the actual daemon controls.

[mydimension]

Seems this has regressed recently. Version 0.001006 at least exhibits this behavior.