Skip to content

ignore file not found when remove file#7

Closed
Cologler wants to merge 1 commit into
symonsoft:masterfrom
Cologler:fix-4
Closed

ignore file not found when remove file#7
Cologler wants to merge 1 commit into
symonsoft:masterfrom
Cologler:fix-4

Conversation

@Cologler
Copy link
Copy Markdown

fixes #4

@tkratky
Copy link
Copy Markdown

tkratky commented Sep 18, 2020

Hello, Who is capable to merge this Pull Request, please? Are there any requirements before the merge? 🙂

@Cologler Cologler closed this Sep 27, 2020
@hkcomori
Copy link
Copy Markdown

What is the reason why this pull request was closed without merging?
I want this change, because posix-ipc does not support Windows (without Cygwin).

@Cologler
Copy link
Copy Markdown
Author

@hkcomori Whatever the PR is merge or not, the package (ilock) still had a huge bug on Linux:

process 1 process 2 process 3
own the lock: {sha256}.ilock (inode is 1)
open {sha256}.ilock (inode is 1)
unlock and delete {sha256}.ilock
open {sha256}.ilock (inode is 2)
lock {sha256}.ilock lock {sha256}.ilock

now both process 2 and process 3 got the lock at the same time.

@hkcomori
Copy link
Copy Markdown

Oh, I see.
We should not unlink the lock file on Linux.
However, in that case, the lock file remains even after all the processes are completed...

@Cologler
Copy link
Copy Markdown
Author

@hkcomori If you want to remove the lock file on Linux, there is a solution at StackOverflow (https://stackoverflow.com/questions/17708885/flock-removing-locked-file-without-race-condition).

I don't care about the lock file, so I am using https://github.com/benediktschmitt/py-filelock now.

@hkcomori
Copy link
Copy Markdown

hkcomori commented Feb 25, 2021

Thanks, py-filelock solved my problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FileNotFoundError when used across ray workers

3 participants