This repository was archived by the owner on Sep 16, 2020. It is now read-only.
Added Symphony Signals API support#108
Merged
ftbb merged 3 commits intosymphonyoss:developfrom Mar 14, 2018
Merged
Conversation
Collaborator
Author
Contributor
|
@ftbb just a head's up that the failure report from cla-bot is incorrect - @Dovie does indeed have a CLA with the Foundation, so you can merge this PR if you're otherwise happy with it. I'm raising a high priority issue with @maoo and @Kabrakssis for them to look at the clabot tomorrow - it seems to be struggling at the moment. |
Contributor
|
Sorry for the problems caused by cla-bot; I checked the logs and it seems that it's a known issue https://github.com/ColinEberhardt/cla-bot/issues/74 . While I work on a fix, @Dovie , could you please check if the email of your git client matches the one of your GitHub account? see octokit/octokit.net#1433 (comment) . TY. /CC @pmonks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#106 - Added support for signals client. NOTE: Advanced responses for subscribe/unsubscribe operations are passing direct API response payloads back.