This repository was archived by the owner on Sep 16, 2020. It is now read-only.
Merged
Conversation
added 3 commits
July 26, 2018 10:17
complete. 2. Set 'active' flag on SymUser when calling getAllUsersWithDetails().
ghost
requested a review
from 
pmonks
reviewed
Aug 14, 2018
symphony-client/src/main/java/org/symphonyoss/symphony/clients/impl/UsersClientImpl.java
Outdated
Show resolved
Hide resolved
SymphonyClientConfig (in response to pull request comments).
Author
|
Updated code in line with previous comments. Thoughts? |
ghost
self-assigned this
Author
|
I will merge this pull request on Tuesday 16th October (2 weeks away). Please raise any concerns prior to this date. |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When calling getAllUsers() the method queries for all Symphony user ids, and then creates a bunch of threads that each queries Symphony POD for the information about a user id. The code currently allows 5 seconds for all users to be returned. After 5 seconds it returns the subset of users that have been added; in BlackRock this means calls to getAllUsers() only returns one third of all users. Additionally the flag indicating if a given SymUser is active, e.g. their account is enabled, is not set.
This pull request: