🐛 fix: Clear cached messages and conversations on sign out#40
🐛 fix: Clear cached messages and conversations on sign out#40TheRealAshik wants to merge 1 commit intopatchfrom
Conversation
- Add `CachedConversationDao` and `CachedMessageDao` via Hilt Injection into `SettingsActivity`. - Update `performLogout` method to call `deleteAll()` on both DAOs. This correctly ensures that when a user switches accounts, the previously cached chat data is completely wiped out, removing stale chats from visibility.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (1 file)
The fix properly addresses the security concern - clearing cached messages and conversations on logout prevents data leakage between accounts. Implementation follows existing patterns with proper Hilt injection and coroutine-based async operations. Reviewed by minimax-m2.5-20260211 · 82,891 tokens |
There was a problem hiding this comment.
Code Review
This pull request modifies the SettingsActivity to clear local database caches during the logout process. It introduces dependencies on CachedConversationDao and CachedMessageDao, invoking their deleteAll methods within the performLogout function prior to signing out. I have no feedback to provide.
Title:
🐞 fix: Clear cached messages and conversations on sign out🐞 Bug Description
🔧 Fix Approach
SettingsActivity.ktto injectCachedConversationDaoandCachedMessageDaovia Hilt. During theperformLogoutflow, it now callsdeleteAll()on both DAOs before performing the sign-out request toauthRepository.🧪 Verification
✅ Build Status
🔗 References
PR created automatically by Jules for task 11760274166966647885 started by @TheRealAshik