196/remove vision#414
Merged
Merged
Conversation
Before: attempt to render a page with the theming service, if fail we use vision Now: The theming service will never fail to render a page The problem with using vision is that when you want to fall back to the templates on disk and you're not in hapi-land you have to do custom logic for that instance. Might as well build that logic into the theming service and everybody can render pages the exact same way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#196
Before: attempt to render a page with the theming service, if fail
we use vision
Now: The theming service will never fail to render a page
The problem with using vision is that when you want to fall
back to the templates on disk and you're not in hapi-land
you have to do custom logic. Might as
well build that logic into the theming service and
everybody can render pages the exact same way.