Skip to content

Fix accept-invite webhooks#545

Closed
chrisshiplet wants to merge 1 commit into
masterfrom
544-fix-accept-invite-webhooks
Closed

Fix accept-invite webhooks#545
chrisshiplet wants to merge 1 commit into
masterfrom
544-fix-accept-invite-webhooks

Conversation

@chrisshiplet
Copy link
Copy Markdown
Contributor

@chrisshiplet chrisshiplet commented Mar 9, 2022

#544

I wasn't super clear from the original PR that introduced this regression (#515) if it was trying to fix something else that I overlooked, but it causes the set password page to POST to the reset password page which bypasses the accept-invite webhook.

@Alexander-Prime
Copy link
Copy Markdown
Contributor

Alexander-Prime commented Mar 10, 2022

This causes a test failure, but the test is just:

GET /user/reset-password
...
  ✖ 48) includes code_challenge in the password recovery form action

It's basically just checking that this line exists. All the other tests pass. I'm trying to work out now why this change was made in the first place.

@spruce-bruce spruce-bruce removed their request for review June 1, 2023 23:00
@Alexander-Prime Alexander-Prime removed their request for review August 2, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants