feat: support multi-client#35
Open
whfuyn wants to merge 2 commits intoforcerelay-sdkfrom
Open
Conversation
|
these test cases have difficult to solve? |
Author
|
Yes, those tests are quite troublesome to fix. We may need to update all of the test data to make it work, but there doesn't seem to be a simple way to reconstruct that data. Additionally, many of the hashes are hard-coded, so we will need to figure out how to obtain the correct hash for each location. |
|
the main function of generating partial ckb transactions works well, so the issue is just waiting to accomplish the corresponding test cases which is a little tough to do |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO:
eth-light-client-in-ckbrepo.