feat: ckb <-> axon transfer test by blckngm · Pull Request #332 · synapseweb3/forcerelay

blckngm · 2023-09-25T08:41:28Z

Description

Added ckb <-> axon, SUDT <-> ERC20 transfer test.

PR author checklist:

Added tests: integration (for Forcerelay) or unit/mock tests (for modules).
Updated code comments and documentation (e.g., docs/).
Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

Reviewed Files changed in the GitHub PR explorer.

ashuralyk · 2023-09-27T04:15:46Z

+        log::info!("Received SUDT");
+
+        // Sleep some time so the ack can be written to axon.
+        std::thread::sleep(Duration::from_secs(60));


can here also run a Js script to listen and check the write-back of ack packet ?

It's certainly possible. What function/event should be checked? Is it AcknowledgePacket?

like using this method to emit a custom event which takes as a symbol of operation finished

I think AcknowledgePacket is better because it doesn't require modifying the contract to emit an event just for testing. I'll try this.

does it work, for listening AcknowledgePacket event from Axon?

It seems like the acknowledge_packet function is never called on axon.

ashuralyk · 2023-09-27T04:24:40Z

please check the CI output and figure out the new added test code was not impacted by the errors from Axon event monitor

https://github.com/synapseweb3/forcerelay/actions/runs/6310730564/job/17133270135?pr=332 (move into Run IBC tests)

blckngm · 2023-09-27T05:35:51Z

The errors are probably from previous tests.

15168316096

See if it is necessary to add lld dependency installation instructions in the readme to prevent errors when compiling axon,
ref:

https://github.com/synapseweb3/forcerelay/blob/ckb-axon-transfer-test/.cargo/config.toml#L2

15168316096 · 2023-09-28T03:58:09Z

 #[async_trait]
 pub trait AxonRpc {
-    async fn get_block_by_id(&self, block_id: BlockId) -> Response<AxonBlock>;
+    async fn get_block_by_id(&self, block_id: BlockId) -> Response<Option<AxonBlock>>;


The addition of Option is to increase the robustness of rpc, but considering that the return type of the interface has also changed, compatibility needs to be considered.

15168316096 · 2023-09-28T06:55:21Z

When you want to verify the integration test locally, you need to pay attention to the environment variables involved in the workflows and whether you need to supplement the local readme instructions. For example, in ubuntu, you can use the following command to carry out the integration test

$ export PATH=$PATH:/tmp/ckb_v0.110.0_x86_64-unknown-linux-gnu @nikaJames95 ➜ /workspaces/forcerelay (ckb-axon-transfer-test) $ export PATH=$PATH:${SRC_DIR}/axon/target/release/ @nikaJames95 ➜ /workspaces/forcerelay (ckb-axon-transfer-test) $ export PATH=$PATH:${SRC_DIR}/ibc-solidity-contract export CHAIN_COMMAND_PATHS="value1,value2" export ACCOUNT_PREFIXES="prefix1,prefix2" export AXON_SRC_PATH="/path/to/axon" export IBC_CONTRACTS_SRC_PATH="/path/to/ibc-solidity-contract" export RUST_LOG="info" export RUST_BACKTRACE="1"

jjyr · 2023-10-07T09:54:15Z

+
+impl TestOverrides for SudtErc20TransferTest {}
+
+impl BinaryConnectionTest for SudtErc20TransferTest {


Is it possible to encapsule these code into this trait?

We can use this contract to replace the default transfer module - the 'Mock' contract

We can refactor this later for a generic transfer test. For now ckb as sink zone is not supported so the only practically supported scenario is CKB source SUDT to/from axon voucher ERC20.

related discussion: #332 (comment)

blckngm force-pushed the ckb-axon-transfer-test branch from 1496f9e to 13051ca Compare September 25, 2023 11:13

Flouse requested review from ashuralyk and jjyr September 26, 2023 01:55

Flouse reviewed Sep 26, 2023

View reviewed changes

Comment thread tools/ibc-test/contracts/version

blckngm force-pushed the ckb-axon-transfer-test branch from e9a7836 to 2b3e86b Compare September 26, 2023 05:45

blckngm marked this pull request as ready for review September 27, 2023 03:10

ashuralyk reviewed Sep 27, 2023

View reviewed changes

Flouse requested a review from 15168316096 September 27, 2023 04:39

15168316096 mentioned this pull request Sep 27, 2023

feat: update ckb-ics and test sudt-transfer synapseweb3/forcerelay-ckb-sdk#17

Merged

Flouse mentioned this pull request Sep 27, 2023

Forcerelay Tracking Issues #326

Open

39 tasks

Flouse approved these changes Sep 27, 2023

View reviewed changes

15168316096 reviewed Sep 28, 2023

View reviewed changes

Flouse reviewed Sep 30, 2023

View reviewed changes

Comment thread tools/ibc-test/src/tests/ibc/sudt_erc20_transfer.rs

Flouse mentioned this pull request Sep 30, 2023

axon_event_monitor Error: Websocket closed unexpectedly #339

Closed

1 task

ashuralyk approved these changes Oct 7, 2023

View reviewed changes

blckngm added 12 commits October 7, 2023 17:10

Update ckb-ics and contracts

801f478

WIP: ckb <-> axon transfer test

1384cf8

fix recv packet tx convert

3b2e42c

write_ack to receive sudt from transfer

3b199b4

consume ack, sleep

8676cd9

Update IBC_CONTRACT_COMMIT

ee20571

fix import and clippy

f3aa510

fmt

a6cb216

fix client id in ckb4ibc monitor fetch_connection_events

364f9f2

Stop axon monitor when endpoint shuts down

41d3525

Update forcerelay-ckb-sdk

de7db7b

Upgrade rust and fix clippy warnings

a20e0be

blckngm force-pushed the ckb-axon-transfer-test branch from b255da8 to a20e0be Compare October 7, 2023 09:19

jjyr reviewed Oct 7, 2023

View reviewed changes

Flouse linked an issue Oct 7, 2023 that may be closed by this pull request

axon_event_monitor Error: Websocket closed unexpectedly #339

Closed

1 task

jjyr approved these changes Oct 8, 2023

View reviewed changes

Flouse merged commit cebfec8 into main Oct 8, 2023

Flouse deleted the ckb-axon-transfer-test branch October 8, 2023 03:38

blckngm mentioned this pull request Oct 8, 2023

CKB ack is not written to axon in ckb <-> axon transfer test #341

Closed


		impl TestOverrides for SudtErc20TransferTest {}

		impl BinaryConnectionTest for SudtErc20TransferTest {

Conversation

blckngm commented Sep 25, 2023 • edited by Flouse Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

PR author checklist:

Reviewer checklist:

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ashuralyk commented Sep 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

blckngm commented Sep 27, 2023

Uh oh!

15168316096 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

15168316096 Sep 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jjyr Oct 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

blckngm commented Sep 25, 2023 •

edited by Flouse

Loading

ashuralyk commented Sep 27, 2023 •

edited

Loading

15168316096 Sep 28, 2023 •

edited

Loading

jjyr Oct 7, 2023 •

edited

Loading