fix: check monitor threads are still working after ibc tests#334
Merged
Conversation
blckngm
approved these changes
Sep 27, 2023
Flouse
approved these changes
Sep 27, 2023
1 task
ashuralyk
approved these changes
Oct 7, 2023
Contributor
ashuralyk
left a comment
There was a problem hiding this comment.
for just solving the throw of failures in monitor, this PR is supposed to merge
Contributor
|
@jjyr I noticed the test between Axon and Axon has failures but CI also passed, please see this:
|
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fix monitor silently crashed issue #330 (comment)
We noticed sometimes CI returns success but the monitor thread is crashed silently, which is unexpected.
This PR adds code to check monitor is working at the end of ibc tests, and returns an error if it isn't working.
We call subscribe function of ChainEndpoint to check the monitor thread, if the monitor is crashed, the subscribe will return a
SendErrorerror, we converted it toError::Relayer.