Skip to content

Toasts v59#500

Merged
ovitrif merged 17 commits intomasterfrom
feat/toast-v59
Dec 9, 2025
Merged

Toasts v59#500
ovitrif merged 17 commits intomasterfrom
feat/toast-v59

Conversation

@jvsena42
Copy link
Copy Markdown
Member

@jvsena42 jvsena42 commented Dec 5, 2025

FIGMA

Description

This PR implements the toasts v59

Preview

Screen_recording_20251205_173152.webm

QA Notes

To mock more easily:

                        TabBar(
                            hazeState = hazeState,
                            onSendClick = { appViewModel.toast(
                                Toast(
                                    type = Toast.ToastType.SUCCESS,
                                    title = "You're Back Online!",
                                    description = "Successfully reconnected to the Internet.",
                                    autoHide = true,
                                )
                            ) },
                            onReceiveClick = { appViewModel.toast(
                                Toast(
                                    type = Toast.ToastType.INFO,
                                    title = "General Message",
                                    description = "Used for neutral content to inform the user.",
                                    autoHide = false,
                                )
                            ) },
                            onScanClick = { navController.navigateToScanner() },
                            modifier = Modifier.align(Alignment.BottomCenter)
                        )

@jvsena42 jvsena42 self-assigned this Dec 5, 2025
@jvsena42 jvsena42 requested a review from Copilot December 5, 2025 20:38
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR implements the new toasts design (v59) with significant visual and interaction improvements. The changes introduce a modern glassmorphic appearance using Haze effects, swipe-to-dismiss gesture support, and improved animations.

Key Changes

  • Added swipe-to-dismiss gesture support with upward drag detection and spring-back animation
  • Replaced gradient backgrounds with glassmorphic Haze effects for a modern iOS-style appearance
  • Improved toast positioning and visual hierarchy with better shadows and spacing

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

File Description
ToastView.kt Complete redesign of toast UI with Haze effects, drag gestures, improved animations, and updated preview examples
MainActivity.kt Added HazeState initialization and integration to enable the new glassmorphic toast appearance

@jvsena42 jvsena42 enabled auto-merge December 8, 2025 09:52
ovitrif
ovitrif previously approved these changes Dec 8, 2025
Copy link
Copy Markdown
Collaborator

@ovitrif ovitrif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tAck w. some nits

@jvsena42 jvsena42 marked this pull request as draft December 8, 2025 17:25
auto-merge was automatically disabled December 8, 2025 17:25

Pull request was converted to draft

@jvsena42
Copy link
Copy Markdown
Member Author

jvsena42 commented Dec 8, 2025

Draft to implement adjustments

@jvsena42 jvsena42 marked this pull request as ready for review December 8, 2025 17:50
@jvsena42
Copy link
Copy Markdown
Member Author

jvsena42 commented Dec 8, 2025

Screen_recording_20251208_145157.webm

Adjustments implemented

@jvsena42 jvsena42 requested a review from ovitrif December 8, 2025 17:53
@jvsena42 jvsena42 enabled auto-merge December 8, 2025 17:53
ovitrif
ovitrif previously approved these changes Dec 8, 2025
Copy link
Copy Markdown
Collaborator

@ovitrif ovitrif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

Great UI/UX 🥇

Will extract this issue:


Polish Toasts

The last tweak for toasts UI/UX would be to dismiss towards the swiped direction, right now it always animates towards the top.

But this more in scope for another PR which should mainly fix the animation in case of multiple toasts, ie.; Get rid of the auto-dismiss mid-transition which cancels both toasts when a new toast is triggered while an old one is showing.

Recording

transitionsIssues.mp4

@ovitrif
Copy link
Copy Markdown
Collaborator

ovitrif commented Dec 8, 2025

@jvsena42 e2e keeps failing at @send_2.

Pinged @piotr-iohk to check for the root cause, it seems a bit surreal that it can't find the DrawerSettings if I am to follow my understanding of the logged error:

Error log line:
https://github.com/synonymdev/bitkit-android/actions/runs/20037542336/job/57467703647?pr=500#step:14:267

@jvsena42
Copy link
Copy Markdown
Member Author

jvsena42 commented Dec 8, 2025

@jvsena42 e2e keeps failing at @send_2.

Pinged @piotr-iohk to check for the root cause, it seems a bit surreal that it can't find the DrawerSettings if I am to follow my understanding of the logged error:

Error log line:
https://github.com/synonymdev/bitkit-android/actions/runs/20037542336/job/57467703647?pr=500#step:14:267

I checked the video, the drawer is displayed
I suspected the toast could be in front of the drawer and the test fail due to some race condition

@piotr-iohk
Copy link
Copy Markdown
Collaborator

The tests have been updated and pass now. I also pushed here 0a25d0a a test tag for SpendingBalanceReadyToast.

Unrelated to this PR, but created this ticket as @onboarding_2 fails randomly recently: #507

@jvsena42 jvsena42 requested a review from ovitrif December 9, 2025 09:46
@ovitrif ovitrif disabled auto-merge December 9, 2025 10:42
@ovitrif ovitrif merged commit 3cc5501 into master Dec 9, 2025
19 of 22 checks passed
@ovitrif ovitrif deleted the feat/toast-v59 branch December 9, 2025 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants