fix: update balance on channel close from connections#774
Merged
Conversation
Contributor
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
Member
Author
|
the transfer card was eventually dismissed after the channel closing confirmation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #721
Description
This PR creates a transfer activity record when closing a channel from the Connections screen, matching the existing behavior in the Transfer to Savings flow.
When closing via Connections > Detail > Close Connection, no
TransferEntitywas created, soDeriveBalanceStateUseCasehad no record to subtract the closing channel's balance from the displayed spending total. The Transfer to Savings flow already handled this correctly by callingtransferRepo.createTransfer()with typeCOOP_CLOSEafter a successful close.Preview
Screen_recording_20260210_141203.webm
QA Notes