Skip to content

feat: send flow design updates v59#488

Open
pwltr wants to merge 3 commits intomasterfrom
feat/send-v59
Open

feat: send flow design updates v59#488
pwltr wants to merge 3 commits intomasterfrom
feat/send-v59

Conversation

@pwltr
Copy link
Contributor

@pwltr pwltr commented Mar 12, 2026

Description

This PR updates the send flow to conform with the new design update v59.

  • add camera permission UI
  • add button to hide/show details on confirm screen
  • add ability to switch payment method (savings/spending) on confirm screen
  • show relative date time for invoice expiry
  • add image animation for swiper
  • refactoring and cleanup

Screenshot / Video

Simulator Screenshot - iPhone 17 - 2026-03-12 at 12 52 00
Simulator.Screen.Recording.-.iPhone.17.-.2026-03-18.at.09.25.13.mov

@pwltr pwltr force-pushed the feat/send-v59 branch 2 times, most recently from dbadff3 to 3ec9820 Compare March 12, 2026 22:02
@pwltr pwltr self-assigned this Mar 13, 2026
@pwltr pwltr added this to the 2.2.0 milestone Mar 13, 2026
@pwltr pwltr marked this pull request as ready for review March 18, 2026 08:33
@claude

This comment has been minimized.

@pwltr
Copy link
Contributor Author

pwltr commented Mar 23, 2026

@piotr-iohk E2E tests seem to not pass onboarding for some reason

@piotr-iohk
Copy link
Collaborator

@piotr-iohk E2E tests seem to not pass onboarding for some reason

It was probably the update screen, merging in master should hopefully resolve it 🤞

@piotr-iohk
Copy link
Collaborator

It was also "camera permissions alert" that was blocking (should be handled now).
The other thing is that the alert (if not accepted or denied) stays displayed even if the app gets terminated, doesn't look like this would be expected?

Screen.Recording.2026-03-23.at.17.40.04.mov

@pwltr
Copy link
Contributor Author

pwltr commented Mar 23, 2026

It was also "camera permissions alert" that was blocking (should be handled now). The other thing is that the alert (if not accepted or denied) stays displayed even if the app gets terminated, doesn't look like this would be expected?

Screen.Recording.2026-03-23.at.17.40.04.mov

For me it doesn't let me terminate the app while this dialog is showing on the simulator or device. Maybe something e2e specific? Is the app crashing or why is it terminated?

@piotr-iohk
Copy link
Collaborator

It was also "camera permissions alert" that was blocking (should be handled now). The other thing is that the alert (if not accepted or denied) stays displayed even if the app gets terminated, doesn't look like this would be expected?
Screen.Recording.2026-03-23.at.17.40.04.mov

For me it doesn't let me terminate the app while this dialog is showing on the simulator or device. Maybe something e2e specific? Is the app crashing or why is it terminated?

Yes, it doesn't let the app terminate. (In the recording I terminated it with xcrun simctl terminate booted to.bitkit). It might affect e2e tests in a way if certain test misses hitting Allow (or somehow fails on that screen), then all the subsequent tests are blocked by this window, even though new instance of the app is started every time.

@pwltr
Copy link
Contributor Author

pwltr commented Mar 23, 2026

It was also "camera permissions alert" that was blocking (should be handled now). The other thing is that the alert (if not accepted or denied) stays displayed even if the app gets terminated, doesn't look like this would be expected?
Screen.Recording.2026-03-23.at.17.40.04.mov

For me it doesn't let me terminate the app while this dialog is showing on the simulator or device. Maybe something e2e specific? Is the app crashing or why is it terminated?

Yes, it doesn't let the app terminate. (In the recording I terminated it with xcrun simctl terminate booted to.bitkit). It might affect e2e tests in a way if certain test misses hitting Allow (or somehow fails on that screen), then all the subsequent tests are blocked by this window, even though new instance of the app is started every time.

There is not much we can do to prevent this, this dialog is entirely managed by the operating system, I guess that is also why it stays there even if the app that called the API is terminated. Do you think it is better to skip asking for camera permission in e2e tests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants