This repository was archived by the owner on Aug 9, 2023. It is now read-only.
Fix addAttribute for React
#8
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In React only both
data-*andalia-*are kebabCase, Otherwise all camelCase.https://facebook.github.io/react/docs/dom-elements.html
So this purposes to output property names that is not included in property-information as camelCase not kebabCase. The properties is a few but includes
viewBox. SVG can't live withoutviewBox, right?I have already rewritten the test a bit, but I am not sure if it is correct.
Torned to PR between property-information and here but I had no courage to touch the former.
thanks