feat(scan): add warning for weekly downloads lookup fallback#42
Merged
feat(scan): add warning for weekly downloads lookup fallback#42
Conversation
- track weekly downloads lookup fallback in npm package metadata fetching - surface a single aggregated scan warning when one or more package lookups fall back to unknown - reuse the existing warnings channel for rendering and JSON output - avoid warning on synthetic project roots where weekly_downloads is expected to be null - keep scoring and scan result behavior unchanged - add coverage for: - downloads lookup fallback - successful downloads lookup - synthetic project-root null handling - stable warning rendering verification: - pnpm test - pnpm run build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an explicit scan warning when weekly downloads lookup falls back to unknown for one or more packages.
Changes
Updated
src/adapters/npm-package-metadata-source.tssrc/application/scan-package.tssrc/domain/contracts.tsTests
test/npm-package-metadata-source.test.tstest/scan-package.test.tstest/plain-text-renderer.test.tsBehavior
warnings[]channelweekly_downloads: nullVerification
pnpm testpnpm run build