fix(persistence): align scan-level explanation with primary finding#43
Merged
fix(persistence): align scan-level explanation with primary finding#43
Conversation
- add `primary_finding_key` to persisted scan records - when primary finding is transitive, clear top-level signals and record primary finding key - preserve existing behavior for root-level findings and no-finding cases - backfill `primary_finding_key` for legacy records during normalization when applicable - add regression tests for: - transitive primary finding persistence behavior - root-level finding behavior unchanged - JSONL round-trip and legacy normalization handling verification: - pnpm test - pnpm run build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Aligns persisted scan-record explanation fields with the primary finding when it is transitive.
Changes
Updated
src/application/scan-package.tssrc/domain/contracts.tssrc/domain/scan-review-records.tsTests
test/scan-package.test.tstest/jsonl-scan-review-store.test.tsBehavior
primary_finding_keyto persisted scan recordsprimary_finding_keyfor legacy records during normalizationVerification
pnpm testpnpm run build