Skip to content

refactor(classification): centralize security deprecation detection#44

Merged
saraeloop merged 1 commit intomainfrom
refactor/security-deprecation-classifier
Apr 8, 2026
Merged

refactor(classification): centralize security deprecation detection#44
saraeloop merged 1 commit intomainfrom
refactor/security-deprecation-classifier

Conversation

@saraeloop
Copy link
Copy Markdown
Member

Summary

Centralizes security-related deprecation classification into a single shared classifier.

Changes

Added

  • src/domain/security-deprecation.ts
  • test/security-deprecation.test.ts

Updated

  • src/domain/value-objects.ts
  • src/application/evaluation-readiness.ts

Behavior

  • Uses one shared classifier for security-related deprecation detection
  • Removes duplicated matching logic from scorer and evaluation paths
  • Keeps presentation logic unchanged and signal-driven

Verification

  • pnpm test
  • pnpm run build

- add shared security deprecation classifier in domain
- update scorer logic to use the shared classifier
- update evaluation readiness logic to use the shared classifier
- remove duplicated security deprecation matching logic
- keep presentation logic unchanged so it continues to consume signal types only

- add focused classifier tests for:
  - security vulnerability wording
  - structured CVE identifiers
  - rejecting unrelated bare cve mentions

verification:
- pnpm test
- pnpm run build
@saraeloop saraeloop merged commit f92b167 into main Apr 8, 2026
1 check passed
@saraeloop saraeloop deleted the refactor/security-deprecation-classifier branch April 8, 2026 03:24
@saraeloop saraeloop self-assigned this Apr 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant