fix(persistence): suppress no-op scan record appends#45
Merged
Conversation
- compare candidate scan record against latest baseline-matching record - skip append when scan substance is unchanged - ignore run-scoped fields (record_id, created_at, baseline_record_id, scan_duration_ms, review-target ids) - ignore age_days drift to avoid time-based duplicate records - return existing persisted record for no-op rescans to keep downstream behavior consistent - add regression coverage for: - identical rescans not appending - materially changed scans still appending - baseline lookup using latest persisted record after suppression - integrated history scenario with single persisted row verification: - pnpm test - pnpm run build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Suppresses duplicate scan records when a rescan produces no material changes, improving scan history quality and baseline behavior.
Changes
Updated
src/application/scan-package.tsTests
test/scan-package.test.tstest/integrated-scenarios.test.tsBehavior
age_daysdrift during comparisonVerification
pnpm testpnpm run build