feat(metadata): add explicit missingness contract for metadata fields#46
Merged
feat(metadata): add explicit missingness contract for metadata fields#46
Conversation
- introduce metadata field state model (observed_present, observed_absent, unavailable, not_applicable) - add node-level helpers for dependents_count and has_advisories - interpret dependents_count:null as unavailable unless a real value is present - interpret has_advisories:false as unavailable until advisory ingestion exists - update evaluation-readiness to use field-state helpers instead of raw null/false checks - tighten reliability guidance in field-reliability-policy to reflect missingness semantics - add regression coverage for field-state behavior and evaluation-readiness integration docs(tsdoc): standardize TSDoc across exported surface - add TSDoc to domain contracts/entities/value objects, application use cases, adapters, interface renderers, and CLI entrypoints - integrate metadata-field-state into a consistently documented API surface verification: - pnpm test - pnpm run build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Introduces an explicit metadata missingness contract and aligns exported code with consistent TSDoc documentation.
Changes
Metadata semantics
observed_present,observed_absent,unavailable,not_applicable)dependents_countandhas_advisoriesnull/falseinterpretation with explicit semanticsDocumentation
srcsurface (domain, application, adapters, interface, CLI)Tests
Behavior
Verification
pnpm testpnpm run buildNotes