fix(store): harden persisted saved-role loading#53
Merged
synsoftworksdev merged 1 commit intomainfrom Apr 15, 2026
Merged
Conversation
Validate persisted saved-role data at load time so malformed or partially corrupted role files fail clearly and consistently. Also: - add `InvalidSavedRoleDataError` in `src/adapters/role-store.ts` - reject invalid JSON in the saved roles file - reject the wrong top-level shape - reject malformed role entries and bad field types - reject invalid persisted role names - fail the entire load on mixed valid/invalid entries - keep the user-facing error message consistent: `saved role data is invalid; fix or recreate the roles file` - add adapter and CLI coverage for the invalid persisted-data cases Verified with: - npm run build - npm test - npm run test:e2e - npm run test:release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Harden persisted saved-role loading so malformed or partially corrupted role
data fails early and predictably instead of surfacing low-level parse/shape
errors.
Changed
InvalidSavedRoleDataErrorinsrc/adapters/role-store.tssaved role data is invalid; fix or recreate the roles fileVerification
npm run buildnpm testnpm run test:e2enpm run test:releaseNotes