Allow either MySQLdb and PyMySQL and add -s/--socket option#1
Open
jhriggs wants to merge 3 commits intosysown:masterfrom
Open
Allow either MySQLdb and PyMySQL and add -s/--socket option#1jhriggs wants to merge 3 commits intosysown:masterfrom
jhriggs wants to merge 3 commits intosysown:masterfrom
Conversation
- Try to import MySQLdb first and fall back to PyMySQL. - Add -s/--socket option to use UNIX sockets in addition to TCP. - No reason to call get_pa_cursor() with the same arguments every time.
…can output help and errors
pondix
reviewed
May 1, 2020
pondix
left a comment
pondix
left a comment
There was a problem hiding this comment.
Looks really good, all positive improvements.
All that remains is to test and merge if OK.
Thank you very much, this is great work!
|
Probably a good approach will be leave the flake8 commit out of a feature request, so you can review just the changes and not ALL as flake8 touch every line. |
|
Friendly ping, can this be merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are 3 commits that I left separate in this PR, so you can pick and choose if you like:
MySQLdbor the less "heavy"PyMySQL.argparsehelp and errors to display. (They are currently unavailable/hidden due tonpyscreen.)e5b7da3, is purely PEP8 formatting to makeflake8happy, which you may not desire.