Detect workflow file changes to trigger LKL build#54
Merged
jserv merged 1 commit intosysprog21:mainfrom Apr 9, 2026
Merged
Conversation
rota1001
changed the title
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
jserv
reviewed
Apr 9, 2026
Previously, the nightly LKL build only checked the hash of the LKL commit, so the build process will only be triggered when the upstream LKL has new commit. However, if the build-lkl.yml is updated, the LKL should be rebuilt. This checks not only the LKL commit hash but the hash of build-lkl.yml to ensure the build process is triggered when build-lkl.yml is updated. Change-Id: I8db1dc2c1fea03bd8dc85d767e6298739d4a9f35
Contributor
|
Thank @rota1001 for contributing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the nightly LKL build only checked the hash of the LKL commit, so the build process will only be triggered when the upstream LKL has new commit. However, when the build-lkl.yml is updated, the LKL should be rebuilt.
This checks not only the LKL commit hash but the hash of build-lkl.yml to ensure the build process is triggered when build-lkl.yml is updated.
This GitHub Action is tested on my repo. When the build-lkl.yml was updated, the build process was triggered[1] even if the upstream LKL remained the same as the last nightly LKL release. After that, when the other GitHub Action was run, the build process was not triggered[2] since the hash of build-lkl.yml remained the same.
[1] https://github.com/rota1001/kbox/actions/runs/24188685186
[2] https://github.com/rota1001/kbox/actions/runs/24188694374
Summary by cubic
Nightly LKL builds now trigger when either the upstream LKL commit changes or when the
build-lkl.ymlworkflow changes. This makes sure workflow updates take effect immediately.check-upstreamto hash.github/workflows/build-lkl.yml.yml_hash; trigger if upstream commit oryml_hashdiffer from the last nightly, otherwise skip.yml_hashto release notes for traceability.Written for commit 000074b. Summary will update on new commits.