bootctl: minor tweaks#41695
Merged
Merged
Conversation
If unprivileged_mode is false then verify_esp() will treat access errors like any other and log about them. Here we set it to false, hence there's no point to log a 2nd time.
This changes boot_config_load_and_select() to also take the root path as input, just like the ESP and XBOOTLDR path. This has the benefit of making the whole file independent of bootctl.c, which means we can link it into a separate test, and is preparatory work for a follow-up commit.
poettering
added
sd-boot/sd-stub/bootctl
please-review
bluca
approved these changes
Apr 17, 2026
bluca
added
good-to-merge/waiting-for-ci 👍
Claude review of PR #41695 (b54af7c)PR looks good. Two clean commits:
No issues found. |
github-actions
Bot
removed
the
good-to-merge/waiting-for-ci 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is split out of #41543, but makes sense on its own.