This repository was archived by the owner on Feb 6, 2026. It is now read-only.
fix: bump docker-api crate to git ref#2903
Merged
si-bors-ng[bot] merged 1 commit intomainfrom Oct 26, 2023
Merged
Conversation
jhelwig
approved these changes
Oct 26, 2023
Contributor
Author
|
Confirmed expected fix is in downstream package: Confirmed via |
Contributor
Author
|
bors merge |
Contributor
|
Build succeeded: |
nickgerace
reviewed
Oct 26, 2023
Contributor
nickgerace
left a comment
There was a problem hiding this comment.
Great PR description too! We need more of these.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: Discord issue regarding issues with SI Launcher.
Bump models to v1.43 was merged into the docker-api crate on 10th June
The commit/change never made it into the crate itself, being last published on 5th June (0.14.0): There isn't a version of this crate with the updated option config in it
To that end, moved to using a git reference off HEAD for the build.
NB: It's noteworthy we have two different crates for docker-api interaction across our monorepo: bollard and docker-api. I suggest at some point we consolidate these/use the most common one.
Added
:sibuild target for Buck for convenience