Conversation
katataku
reviewed
Jan 25, 2025
|
|
||
| class Solution: | ||
| def numUniqueEmails(self, emails: List[str]) -> int: | ||
| def validate(email: str) -> bool: |
There was a problem hiding this comment.
validかどうかを判定しboolを返す関数なのでis_validという関数名がわかりやすいと思いました
nodchip
reviewed
Jan 25, 2025
| if not domain.removesuffix('.com'): | ||
| return False | ||
| return True | ||
| def normalize(email: str) -> str: |
There was a problem hiding this comment.
比較のために正規化しているため canonicalize のほうが良いと思います。内部的な冗長さの削減のために正規化するのを normalize と呼ぶようです。
oda
reviewed
Jan 26, 2025
Comment on lines
+155
to
+157
| unique_emails = set() | ||
| for email in emails: | ||
| unique_emails.add(normalize(email)) |
There was a problem hiding this comment.
内包表記も可能ですがループを回す方が見やすいかもしれませんね。
unique_emails = {normalize(email) for email in emails}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://leetcode.com/problems/unique-email-addresses/description/