Push code for 2.12 #259
Merged
Push code for 2.12 #259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jacalata
commented
Jul 27, 2023
jacalata
commented
- list site content Jac/content listing #230
- logging Always log version #234
- Readme updates Jac/readme updates #235
- More options on publishing Jac/parse publish options #236
- proxy settings proxy settings #241
- token-file option add --token-file option #243
Unable to add a user to a group with tabcmd 2.0 if username contains uppercase
* handle exit with no logger * redact logging token, also clean up exit a little * add logging to check signin failure * remove duplicate log lines * refactor: extract strings to local dictionary to make it easier to extract to another file * add error handling around session file data * add flows and object detail to list output * some test coverage
* encoding filter values to handle spaces and special chars in filters * added new --filter option to pass in un-encoded value for simpler input * refactoring order of args, method names * stopped sending filters for workbooks
* add --url, --include-all/--embedded-datasources for create/refresh/delete extract commands * replace polling code with library call * add views to workbook listing
* remove 'known gaps' and pointed to release notes. * add log statement explaining workbooks won't be filtered * edit contributing file * add python 3.11
When people ask for help they usually show default logs and don't know what version they have.
* add tests * format error output * add ID to output, add a "nothing found" message instead of just exiting silently.
* implement thumbnail options. (including 'not yet implemented' message for --thumbnail-group) * Implement overwrite/append/replace arguments (including not-yet-implemented message for --replace) * clarified help content for extract-encryption and some other not-implemented options * added tests for all valid publish command options * error log cleanup: better stacktrace, less repetition
* implement --proxy, --no-proxy options * implement but not tested --use-certificate option * tweak output * specify black version
* freeze tsc dependency to 0.25
* Update session.py * update test for new functionality
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| self.logger.info("===== Username: {}".format(self.username)) | ||
| if self.certificate: | ||
| self.logger.info("===== Certificate: {}".format(self.certificate)) | ||
| else: |
Check failure
Code scanning / CodeQL
Clear-text logging of sensitive information
anyoung-tableau
approved these changes
Jul 27, 2023
Also change a print statement to log statement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.